Skip to content

feat: add version metadata and -v/--version flag#70

Open
leno23 wants to merge 1 commit into
dolph:mainfrom
leno23:feat/version-flag-issue-26
Open

feat: add version metadata and -v/--version flag#70
leno23 wants to merge 1 commit into
dolph:mainfrom
leno23:feat/version-flag-issue-26

Conversation

@leno23
Copy link
Copy Markdown

@leno23 leno23 commented May 30, 2026

Summary

Fixes #26. Adds version.go for build.sh ldflags and supports -v/--version.

Test plan

  • go test ./...

Made with Cursor

Closes dolph#26. Declare ldflags-injected build variables and print them when
-v or --version is passed.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c1275adfa3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread find_replace.go
// Remove date/time from logging output.
log.SetFlags(0)

if len(args) == 2 && (args[1] == "-v" || args[1] == "--version") {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Document the new version flag in the README

This adds a new CLI flag, but the README was not updated in the same change. The repo instructions in AGENTS.md state: “Adding a flag or subcommand requires updating the README in the same PR,” so users reading the documented CLI surface still only see find-replace FIND REPLACE and have no discoverable mention of -v/--version.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build-time version metadata is injected via -ldflags but never referenced; no --version flag

1 participant