feat: add version metadata and -v/--version flag#70
Conversation
Closes dolph#26. Declare ldflags-injected build variables and print them when -v or --version is passed.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1275adfa3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Remove date/time from logging output. | ||
| log.SetFlags(0) | ||
|
|
||
| if len(args) == 2 && (args[1] == "-v" || args[1] == "--version") { |
There was a problem hiding this comment.
Document the new version flag in the README
This adds a new CLI flag, but the README was not updated in the same change. The repo instructions in AGENTS.md state: “Adding a flag or subcommand requires updating the README in the same PR,” so users reading the documented CLI surface still only see find-replace FIND REPLACE and have no discoverable mention of -v/--version.
Useful? React with 👍 / 👎.
Summary
Fixes #26. Adds
version.gofor build.sh ldflags and supports-v/--version.Test plan
go test ./...Made with Cursor